Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump golang, antlr and rule parser version #265

Merged

Conversation

ZhiHanZ
Copy link
Contributor

@ZhiHanZ ZhiHanZ commented Jul 5, 2022

Description

Problem:
Antlr have upgraded with some breaking change which impacts the rule parser used by feature flags and was resolved (nikunjy/rules#24), thus far we could also update dependencies related to it, and also bump go version to 1.17

Changes include

  • Bugfix (non-breaking change that solves an issue)

Closes issue(s)

Resolve #

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /docs)
  • I have followed the contributing guide

@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.975% when pulling 5760ed5 on ZhiHanZ:chore/bump-antlr-parser into 8add26f on thomaspoignant:main.

@thomaspoignant
Copy link
Owner

Thanks a lot for this pull request, I will merge this and will release a new version.
I would be interested to understand what was your issue with this version of nikunjy/rules, what was not working as expected?

@thomaspoignant thomaspoignant merged commit a318d31 into thomaspoignant:main Jul 5, 2022
@ZhiHanZ
Copy link
Contributor Author

ZhiHanZ commented Jul 5, 2022

Thanks a lot for this pull request, I will merge this and will release a new version. I would be interested to understand what was your issue with this version of nikunjy/rules, what was not working as expected?

My code works with updated Antlr version which was not compatible with the old one :(, as documented in here antlr/antlr4#3188, thus far I have noticed that nikunjy/rules also encountered this issue (nikunjy/rules#22) and release a patch to fix it. I tried to fix it by adopting the update and it works, and I think this patch could also help other people understand and fix the same incompatibility problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants