New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add reason and errorCode from open-feature #269

Merged

thomaspoignant merged 2 commits into main from feat-flag-resolution

Jul 18, 2022

Owner

thomaspoignant commented Jul 18, 2022

Description

Following the open-feature specs this pull request adds the reason and error code into the VariationResult to be able to expose them in the relay proxy.

This does not change anything for the actual usage of the SDK.

Changes include

Bugfix (non-breaking change that solves an issue)
New feature (non-breaking change that adds functionality)
Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #268

Checklist

I have tested this code
I have added unit test to cover this code
I have updated the documentation (README.md and /docs)
I have followed the contributing guide


          Add reason and errorCode from open-feature

2c59c99

Signed-off-by: Thomas Poignant <[email protected]>

coveralls commented Jul 18, 2022 •

edited

Loading

Coverage increased (+0.4%) to 94.757% when pulling a02d0cf on feat-flag-resolution into 96db56d on main.


          Add one missing test

a02d0cf

Signed-off-by: Thomas Poignant <[email protected]>

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

thomaspoignant merged commit 6e9af48 into main

thomaspoignant deleted the feat-flag-resolution branch

July 18, 2022 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet