New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when calling variation before initialisation #361

Merged

thomaspoignant merged 1 commit into main from fix-360

Oct 5, 2022

Owner

thomaspoignant commented Oct 5, 2022

Description

Fix the error when calling variation before initialization.
The SDK was panicking if ff.BoolVariation or other variations functions were called before the initialization.

This PR ensure that we are not panicking anymore and that we return the default value.

Changes include

Bugfix (non-breaking change that solves an issue)
New feature (non-breaking change that adds functionality)
Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #360

Checklist

I have tested this code
I have added unit test to cover this code
I have updated the documentation (README.md and /docs)
I have followed the contributing guide


          Fix error when calling variation before initialisation

03daa7e

Signed-off-by: Thomas Poignant <[email protected]>

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

thomaspoignant mentioned this pull request

(bug) Nil pointer dereference when calling a variation without Init #360

Closed

coveralls commented Oct 5, 2022

Coverage decreased (-0.09%) to 95.006% when pulling 03daa7e on fix-360 into d6dd663 on main.

thomaspoignant merged commit 47bc6fa into main

thomaspoignant deleted the fix-360 branch

October 5, 2022 07:25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet