Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move metrics package to cmd/relayproxy #560

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Conversation

thomaspoignant
Copy link
Owner

Description

The metrics package was directly under cmd while it is supposed to be under cmd/relayproxy.

Changes include

  • Bugfix (non-breaking change that solves an issue)

Checklist

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 3d42d9f
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/641427d41620d9000865e6ff

@sonarcloud
Copy link

sonarcloud bot commented Mar 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant changed the title Move metrics package to the right place Move metrics package to cmd/relayproxy Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #560 (3d42d9f) into main (07ce2b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #560   +/-   ##
=======================================
  Coverage   89.96%   89.96%           
=======================================
  Files          52       52           
  Lines        2283     2283           
=======================================
  Hits         2054     2054           
  Misses        184      184           
  Partials       45       45           
Impacted Files Coverage Δ
cmd/relayproxy/controller/all_flags.go 85.71% <ø> (ø)
cmd/relayproxy/controller/flag_eval.go 88.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kodiakhq kodiakhq bot merged commit d4424b0 into main Mar 17, 2023
@kodiakhq kodiakhq bot deleted the move-metrics-package branch March 17, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant