Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage #571

Merged
merged 12 commits into from
Mar 18, 2023
Merged

Improve coverage #571

merged 12 commits into from
Mar 18, 2023

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Mar 17, 2023

Description

Coverage went down since the mono repo.
This PR add some tests to improve it.

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have followed the contributing guide

Signed-off-by: Thomas Poignant <[email protected]>
@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 561a2c4
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6415d4fe9a0ddc0008835e98

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #571 (561a2c4) into main (74c7d39) will increase coverage by 0.88%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   86.70%   87.58%   +0.88%     
==========================================
  Files          54       57       +3     
  Lines        2505     2570      +65     
==========================================
+ Hits         2172     2251      +79     
+ Misses        281      271      -10     
+ Partials       52       48       -4     
Impacted Files Coverage Δ
cmd/migrationcli/main.go 19.35% <ø> (ø)
exporter/fileexporter/exporter.go 92.85% <100.00%> (ø)
exporter/logsexporter/exporter.go 85.71% <100.00%> (ø)
exporter/webhookexporter/exporter.go 93.61% <100.00%> (ø)
retriever/fileretriever/retriever.go 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thomaspoignant thomaspoignant marked this pull request as ready for review March 18, 2023 15:14
@kodiakhq kodiakhq bot merged commit 229696f into main Mar 18, 2023
@kodiakhq kodiakhq bot deleted the improve-coverage branch March 18, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant