-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relay-proxy: Add new endpoint to collect flag usage data #650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas Poignant <[email protected]>
✅ Deploy Preview for go-feature-flag-doc-preview canceled.
|
Codecov Report
@@ Coverage Diff @@
## main #650 +/- ##
==========================================
+ Coverage 88.24% 88.40% +0.15%
==========================================
Files 57 58 +1
Lines 2570 2605 +35
==========================================
+ Hits 2268 2303 +35
Misses 252 252
Partials 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
thomaspoignant
force-pushed
the
add-collector-endpoint-relay-proxy
branch
from
March 31, 2023 09:46
f7a2f39
to
aad0f4a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We will introduce soon a cache in the Open Feature providers.
To avoid to lose track of these flag evaluation in the data we export, we need to have a way to send those data to the data exporter.
This PR adds a new endpoint in the relay proxy to send those data in bulk mode to allow them to be saved in the same place as the rest of the data.
Changes include
Checklist
README.md
and/website/docs
)