Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay-proxy: Add new endpoint to collect flag usage data #650

Merged
merged 7 commits into from
Mar 31, 2023

Conversation

thomaspoignant
Copy link
Owner

@thomaspoignant thomaspoignant commented Mar 30, 2023

Description

We will introduce soon a cache in the Open Feature providers.
To avoid to lose track of these flag evaluation in the data we export, we need to have a way to send those data to the data exporter.

This PR adds a new endpoint in the relay proxy to send those data in bulk mode to allow them to be saved in the same place as the rest of the data.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

@netlify
Copy link

netlify bot commented Mar 30, 2023

Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit deda077
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/6426f4162c84850008dc6f55

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #650 (deda077) into main (6db4651) will increase coverage by 0.15%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #650      +/-   ##
==========================================
+ Coverage   88.24%   88.40%   +0.15%     
==========================================
  Files          57       58       +1     
  Lines        2570     2605      +35     
==========================================
+ Hits         2268     2303      +35     
  Misses        252      252              
  Partials       50       50              
Impacted Files Coverage Δ
exporter/feature_event.go 100.00% <ø> (ø)
cmd/relayproxy/controller/collect_eval_data.go 100.00% <100.00%> (ø)
cmd/relayproxy/metric/metrics.go 100.00% <100.00%> (ø)
variation.go 98.20% <100.00%> (+0.01%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
Signed-off-by: Thomas Poignant <[email protected]>
@thomaspoignant thomaspoignant force-pushed the add-collector-endpoint-relay-proxy branch from f7a2f39 to aad0f4a Compare March 31, 2023 09:46
@sonarcloud
Copy link

sonarcloud bot commented Mar 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kodiakhq kodiakhq bot merged commit b58fbe0 into main Mar 31, 2023
@kodiakhq kodiakhq bot deleted the add-collector-endpoint-relay-proxy branch March 31, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant