-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature support-parquet-for-data-collection #667
feature support-parquet-for-data-collection #667
Conversation
✅ Deploy Preview for go-feature-flag-doc-preview ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #667 +/- ##
==========================================
- Coverage 88.99% 88.83% -0.17%
==========================================
Files 58 58
Lines 2618 2661 +43
==========================================
+ Hits 2330 2364 +34
- Misses 237 243 +6
- Partials 51 54 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hello @dhanusaputra, once again thanks a lot for your contribution 🙏 I will review the PR during the week end. |
hi @thomaspoignant no worries, happy to help 🙏 no rush btw, it's still in draft have no idea how to store golang interface{} to parquet type |
72d2952
to
de2be48
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice contribution, I have added a few comments, these are mainly things we should do to avoid reducing the coverage.
But globally this is a super nice addition to GO Feature Flag.
e4e6c0d
to
c6d32c9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dhanusaputra I finally had time to review it more in detail.
Looks good now! Thanks a lot for this contribution.
…et-for-data-collection
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
Changes include
Closes issue(s)
Resolve #157
Checklist
README.md
and/website/docs
)