Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature support-parquet-for-data-collection #667

Merged
merged 8 commits into from
Apr 18, 2023
Merged

feature support-parquet-for-data-collection #667

merged 8 commits into from
Apr 18, 2023

Conversation

dhanusaputra
Copy link
Contributor

@dhanusaputra dhanusaputra commented Apr 7, 2023 •
edited
Loading

Description

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #157

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

@netlify
Copy link

netlify bot commented Apr 7, 2023 •
edited
Loading

✅ Deploy Preview for go-feature-flag-doc-preview ready!

Name Link
🔨 Latest commit 792c99a
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/643e84a035d4640008d8b99c
😎 Deploy Preview https://deploy-preview-667--go-feature-flag-doc-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Merging #667 (792c99a) into main (846a60b) will decrease coverage by 0.17%.
The diff coverage is 82.69%.

@@            Coverage Diff             @@
##             main     #667      +/-   ##
==========================================
- Coverage   88.99%   88.83%   -0.17%     
==========================================
  Files          58       58              
  Lines        2618     2661      +43     
==========================================
+ Hits         2330     2364      +34     
- Misses        237      243       +6     
- Partials       51       54       +3
Impacted Files Coverage Δ
exporter/fileexporter/exporter.go 83.56% <71.87%> (-9.30%) ⬇️
exporter/feature_event.go 100.00% <100.00%> (ø)
exporter/gcstorageexporter/exporter.go 68.00% <100.00%> (+0.65%) ⬆️
exporter/s3exporter/exporter.go 76.92% <100.00%> (+0.45%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@thomaspoignant
Copy link
Owner

Hello @dhanusaputra, once again thanks a lot for your contribution 🙏
This was something I wanted to work on for a super long time, and I am glad to see it happening now.

I will review the PR during the week end.

@dhanusaputra
Copy link
Contributor Author

hi @thomaspoignant no worries, happy to help 🙏

no rush btw, it's still in draft
still not working for Value interface{} data type

have no idea how to store golang interface{} to parquet type
will explore again later
and please let me know if you know about this , thank you

@dhanusaputra dhanusaputra marked this pull request as ready for review April 9, 2023 04:38
@dhanusaputra dhanusaputra force-pushed the feature/support-parquet-for-data-collection branch from 72d2952 to de2be48 Compare April 9, 2023 04:40
thomaspoignant
thomaspoignant reviewed Apr 13, 2023
View reviewed changes
Copy link
Owner

@thomaspoignant thomaspoignant left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nice contribution, I have added a few comments, these are mainly things we should do to avoid reducing the coverage.

But globally this is a super nice addition to GO Feature Flag.

website/docs/relay_proxy/configure_relay_proxy.md Show resolved Hide resolved
exporter/feature_event.go Show resolved Hide resolved
exporter/fileexporter/exporter.go Show resolved Hide resolved
exporter/feature_event.go Show resolved Hide resolved
@dhanusaputra dhanusaputra force-pushed the feature/support-parquet-for-data-collection branch from e4e6c0d to c6d32c9 Compare April 14, 2023 12:24
thomaspoignant
thomaspoignant approved these changes Apr 18, 2023
View reviewed changes
Copy link
Owner

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dhanusaputra I finally had time to review it more in detail.
Looks good now! Thanks a lot for this contribution.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@thomaspoignant thomaspoignant merged commit 4539b15 into thomaspoignant:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspoignant thomaspoignant thomaspoignant approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(feature) support parquet for data collection
2 participants
@dhanusaputra @thomaspoignant