Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix relay proxy config - support parquet for data collection #710

Merged
merged 4 commits into from
Apr 23, 2023
Merged

fix relay proxy config - support parquet for data collection #710

merged 4 commits into from
Apr 23, 2023

Conversation

dhanusaputra
Copy link
Contributor

Description

fix not able to customize parquetCompressionCodec in relay-proxy

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking changes (change that is not backward-compatible and/or changes current functionality)

Closes issue(s)

Resolve #157

Checklist

  • I have tested this code
  • I have added unit test to cover this code
  • I have updated the documentation (README.md and /website/docs)
  • I have followed the contributing guide

@netlify
Copy link

netlify bot commented Apr 22, 2023 •
edited
Loading

✅ Deploy Preview for go-feature-flag-doc-preview canceled.

Name Link
🔨 Latest commit 53889dd
🔍 Latest deploy log https://app.netlify.com/sites/go-feature-flag-doc-preview/deploys/64455c74e4e5eb0008d46b87

@codecov
Copy link

codecov bot commented Apr 22, 2023 •
edited
Loading

Codecov Report

Merging #710 (53889dd) into main (490a46e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #710      +/-   ##
==========================================
+ Coverage   88.89%   88.93%   +0.04%     
==========================================
  Files          58       58              
  Lines        2701     2712      +11     
==========================================
+ Hits         2401     2412      +11     
  Misses        245      245              
  Partials       55       55
Impacted Files Coverage Δ
cmd/relayproxy/config/config.go 94.33% <ø> (ø)
cmd/relayproxy/main.go 0.00% <ø> (ø)
cmd/relayproxy/config/exporter.go 100.00% <100.00%> (ø)
cmd/relayproxy/service/gofeatureflag.go 55.24% <100.00%> (+1.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

thomaspoignant
thomaspoignant reviewed Apr 23, 2023
View reviewed changes
cmd/relayproxy/config/exporter.go Outdated Show resolved Hide resolved
cmd/relayproxy/main.go
"os"

"github.com/spf13/pflag"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will be great to avoid this kind of change in the PR.

thomaspoignant
thomaspoignant approved these changes Apr 23, 2023
View reviewed changes
cmd/relayproxy/config/exporter.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.1% 0.1% Duplication

@kodiakhq kodiakhq bot merged commit f62600e into thomaspoignant:main Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaspoignant thomaspoignant thomaspoignant approved these changes

Assignees

@thomaspoignant thomaspoignant

Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(feature) support parquet for data collection
2 participants
@dhanusaputra @thomaspoignant