Deprecate the webhook field to have the field Notifiers instead #74
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The config field
Webhooks
used to notify an API when a flag has changed is too restrictive because we need to have other types of service to call when a flag has changed.This PR introduces a new field called
Notifiers
in place of theWebhooks
field to be able to have different types of notifiers when a flag has changed (slack can be a great example).Based on that the field
Webhooks
is deprecated and will continue to be supported in the next versions.It will be removed in a future release. (Check migration section bellow to see how to re-configure your webhooks).
This PR contains also a small change around the
HTTPClient
used at different place to have a central place where we can configure it.Migration
If you were using
Webhooks
before, you should have a configuration like this:With
Notifiers
, your configuration should looks like this now:Changes include
Checklist