Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide expiration information for cached results #1614

Open
fridex opened this issue Jan 18, 2022 · 7 comments
Open

Provide expiration information for cached results #1614

fridex opened this issue Jan 18, 2022 · 7 comments
Assignees
@mayaCostantini
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@fridex
Copy link
Contributor

fridex commented Jan 18, 2022

Is your feature request related to a problem? Please describe.

As a user of Thoth, I would like to know when the cached result expires. To support this, I would like to access such information when asking for results.

Describe the solution you'd like

Provide information when the cached result expires (ex. in HTTP headers).
@fridex fridex added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2022
@goern
Copy link
Member

goern commented Jan 19, 2022

/priority important-soon
/help

@sesheta
Copy link
Member

sesheta commented Jan 19, 2022

@goern:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/priority important-soon
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sesheta sesheta added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Jan 19, 2022
@sesheta
Copy link
Member

sesheta commented Apr 19, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2022
@goern
Copy link
Member

goern commented Apr 26, 2022

@fridex could this be part of the meta information work?

/sig stack-guidance
/remove-lifecycle stale
/triage needs-information

@sesheta sesheta added sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/needs-information Indicates an issue needs more information in order to work on it. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 26, 2022
@fridex
Copy link
Contributor Author

fridex commented Apr 26, 2022

Not sure what meta information work you are referring to. If the justification metadata extension we discussed then I don't think so. The cache is maintained by user-api so user-api can expose expiration info to users (regardless of the results returned). Applies to advises and package-extract results.

@sesheta
Copy link
Member

sesheta commented Jul 25, 2022

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2022
@mayaCostantini
Copy link
Contributor

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 25, 2022
@mayaCostantini mayaCostantini mentioned this issue Jul 25, 2022
Open
@mayaCostantini mayaCostantini self-assigned this Aug 9, 2022
@mayaCostantini mayaCostantini mentioned this issue Aug 23, 2022
Closed
2 tasks
@mayaCostantini mayaCostantini mentioned this issue Sep 14, 2022
Merged
@goern goern added priority/backlog Higher priority than priority/awaiting-more-evidence. and removed priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayaCostantini mayaCostantini

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. sig/stack-guidance Categorizes an issue or PR as relevant to SIG Stack Guidance. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
Planning Board
Status: 🏗 In progress
Milestone
No milestone
Development

No branches or pull requests
4 participants
@goern @fridex @sesheta @mayaCostantini