format: only sort tag parameter below name for built-in rules
#3036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `tag` is quite a common parameter name for custom build rules. We only want it to sort below `name` in cases where the parameter's value is actually part of the target name, i.e. for the Please built-ins `build_rule` and `filegroup`. In all other cases, it should sort alphabetically with the unprioritised parameters.
peterebden
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
tagis quite a common parameter name for custom build rules. We only want it to sort belownamein cases where the parameter's value is actually part of the target name, i.e. for the Please built-insbuild_ruleandfilegroup. In all other cases, it should sort alphabetically with the unprioritised parameters.