Change BuildEnv to a map #3144
Merged
Change BuildEnv to a map #3144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decided while working on #3143 that this was messy as a slice. Heaps of code needs to loop over it and do string splitting and whatnot, and keeping on having to worry about duplicating entries which this now just does naturally.
This seems a lot neater. Pretty sure I've caught everywhere that uses it but there's the odd use that can slip through (e.g. iterating the return value of a function without naming the type might still compile).
It's hopefully more efficient, although I doubt it shows up much (whenever we need to construct env vars, we're executing a subprocess which will dominate total time).