Return None for empty optional plugin config fields
#3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifying an empty value for an optional plugin configuration field causes the field to be set to the type's default value (`""` for strings, `0` for integers, `False` for booleans) from the perspective of ASP. This makes it impossible to tell whether an optional field was actually assigned a value inside a `BUILD` file. For optional fields, return `None` if no value is assigned.
peterebden
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifying an empty value for an optional plugin configuration field causes the field to be set to the type's default value (
""for strings,0for integers,Falsefor booleans) from the perspective of ASP. This makes it impossible to tell whether an optional field was actually assigned a value inside aBUILDfile.For optional fields, return
Noneif no value is assigned.