-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rails 8.0 #2705
base: main
Are you sure you want to change the base?
Conversation
So far, this is just a quick first-pass at opening up support, so we can make a little bit of progress with each additional change. As of right now, we're stuck here, as
|
@nickcharlton looks like the |
With I've done a bunch of it, now I'm going to wait for CI to fail and see what else we need to do. |
I'm left fighting with Ruby, Rails versions and testing the combination along with Appraisal on CI. However, those are details in the scheme of getting this PR merged. If someone would like to test it out on their Rails 8.0 upgrade, feel free to go ahead — I'd be especially interested if there are any issues you see which might mean this takes longer than getting CI right. |
We needed to: * Bring over quite a few things from `rails app:update`, which hopefully should make future upgrades easier, * Fix a change to the `enum` `ActiveModel` signature, which changed between Rails 6.0 and 7.0, * Add a version check from 7.0 for `raise_on_missing_callback_actions` https://rubyonrails.org/2024/11/7/rails-8-no-paas-required Closes #2703
8b73057
to
0c13066
Compare
I'd started down the path of messing about with running Appraisals differently, because it was failing for various reasons. But remembered I'd actually started on this back in Feb as #2524. I've now merged that, so we're back in Ruby vs. Rails expected compatibility. It's time to drop some Ruby versions ahead of cutting the final version of v1, but unless this takes longer than today, I'd like to do that after this PR is merged. We'll see how it goes. |
https://rubyonrails.org/2024/11/7/rails-8-no-paas-required
Closes #2703