Commits on Nov 14, 2024

1. Fix query params being clobbered by Clearance::BackDoor …

   In rack 3.1.x Setting Rack::RACK_REQUEST_QUERY_STRING causes rack to think
   that the query string has already been parsed
   (see https://github.com/rack/rack/blob/v3.1.7/lib/rack/request.rb#L487)
   
   This was introduced in #2703 but wasn't actually necessary - the warning mentioned
   in that PR is only triggered if only Rack::RACK_REQUEST_QUERY_STRING is updated,
   but the correct behaviour is to only set Rack::QUERY_STRING, not to set both
   
   Fixes thoughtbot#1040

   

   fcheung committed Nov 14, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a01b72e
   • Browse repository at this point

   Copy the full SHA

   a01b72e View commit details

   Browse the repository at this point in the history