Load rbenv and add trusted binstubs to PATH #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| eval "$(rbenv init - --no-rehash)" | ||
|
|
||
| # mkdir .git/safe in the root of repositories you trust | ||
| export PATH=".git/safe/../../bin:$PATH" |
There was a problem hiding this comment.
Does this need to be within the rbenv if block? Seems like this would work fine even without rbenv. You'd just be using the system Ruby.
There was a problem hiding this comment.
It works outside the conditional. Done in 83bac43
|
This looks good to me. |
Our expected way of managing Rubies is with rbenv: https://github.com/thoughtbot/laptop/blob/master/common-components/ruby-environment This commit loads rbenv in `zshrc` as recommended by the rbenv docs: https://github.com/sstephenson/rbenv#basic-github-checkout Assuming the binstubs for a project are in the local bin/ directory, we can even go a step further to add the directory to shell $PATH so that rspec can be invoked without the bin/ prefix: export PATH="./bin:$PATH" Doing so on a system that other people have write access to (such as a shared host) is a security risk: rbenv/rbenv#309 The `.git/safe` convention addresses the security problem: https://twitter.com/tpope/status/165631968996900865 This zsh fix may be necessary for OS users in order to fix a bug: https://github.com/thoughtbot/laptop/blob/master/mac-components/zsh-fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our expected way of managing Rubies is with rbenv:
https://github.com/thoughtbot/laptop/blob/master/common-components/ruby-environment
This commit loads rbenv in
zshrcas recommended by the rbenv docs:https://github.com/sstephenson/rbenv#basic-github-checkout
Assuming the binstubs for a project are in the local bin/ directory, we can
even go a step further to add the directory to shell $PATH so that rspec can
be invoked without the bin/ prefix:
Doing so on a system that other people have write access to (such as a shared
host) is a security risk:
rbenv/rbenv#309
The
.git/safeconvention addresses the security problem:https://twitter.com/tpope/status/165631968996900865