Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ruby 3.3 deprecation warning #1607

Closed
wants to merge 0 commits into from

Conversation

olegantonyan
Copy link
Contributor

@olegantonyan olegantonyan commented Dec 25, 2023

Fix this warning in Ruby 3.3

warning: observer was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add observer to your Gemfile or gemspec

@mike-burns
Copy link
Contributor

#1608 - this is also my attempt to fix tests.

@mike-burns
Copy link
Contributor

#1609 - still attempting to fix tests. Hold tight.

@mike-burns
Copy link
Contributor

@olegantonyan do you mind rebasing on main? That ought to fix CI.

@mike-burns
Copy link
Contributor

Let's get this out ASAP. I'm going to:

  1. git rebase main
  2. git push --force
  3. git checkout main && git merge olegantonyan-main

Then I'll cut a release.

Thank you for this fast contribution!

@olegantonyan
Copy link
Contributor Author

@mike-burns sure! thank you

@mike-burns
Copy link
Contributor

I screwed something up but it's in as adc4857.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants