This repository has been archived by the owner on Jun 20, 2019. It is now read-only.
Introduce check and uncheck async helpers
#9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
sd-checkbox-helpers
branch
2 times, most recently
from
c2c62c0
to
fe01b3b
Compare
seanpdoyle
added a commit
to seanpdoyle/ember.js
that referenced
this pull request
Nov 2, 2015
The `ember-testing-checkbox-helpers` feature hasn't gained traction and should be considered a failure as an Ember.js feature. The helpers have been extracted into [thoughtbot/ralphs-little-helpers]. [thoughtbot/ralphs-little-helpers]: thoughtbot/ralphs-little-helpers#9
Promotes `check` and `uncheck` test helpers from [emberjs/ember.js] from behind the [ember-testing-checkbox-helpers] feature flag. Matches Capybara's [#check] and [#uncheck] helper methods. Additionally introduces `assert.checked` and `assert.unchecked` QUnit assertions. [ember-testing-checkbox-helpers]: https://github.com/emberjs/ember.js/blob/860bb4be498466ac4c914adb1f139e5cd2fbc123/FEATURES.md#feature-flags [emberjs/ember.js]: emberjs/ember.js#9798 [#check]: http://www.rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Actions#check-instance_method [#uncheck]: http://www.rubydoc.info/github/jnicklas/capybara/master/Capybara/Node/Actions#uncheck-instance_method
seanpdoyle
force-pushed
the
sd-checkbox-helpers
branch
from
fe01b3b
to
6797f79
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promotes
checkandunchecktest helpers from emberjs/ember.js frombehind the ember-testing-checkbox-helpers feature flag.
Matches Capybara's #check and #uncheck helper methods.
Additionally introduces
assert.checkedandassert.uncheckedQUnitassertions.