Update README [ci skip] #1348
Merged
Update README [ci skip] #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that it is pretty large and I think this will help a lot. Thank you! |
Merged
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The association_matcher.rb is a big file and has more than one matcher inside. This PR update the links to redirect the user to where the description of the matcher starts.
This strategy is already used on the links of these matchers: use_after_action, use_around_action and use_before_action.
I'm still working on the PR #1341 and that's why I'm finding these details. I'm learning a lot more about this gem. Thanks.
Another possible contribution, if anyone is interested, is to add an example of using have_attached_matchers within the file like the other matchers. I think it would be great to add that.