Remove Rails 6.0.z support #1548
Conversation
|
@HeitorMC Thanks for this. Would you mind updating the "Compatibility" section of the README? I think it references Rails 5.2+ as being supported. Also, since this PR also removes Rails 5.2 in addition to 6.0.x, do you mind updating the PR title to include that information? |
Sure!
Ohh, my bad. I did this because this #1522 wasn't merged yet. So I added Douglas's changes into my pr, then, once his pr gets merged, mine PR won't have conflicts. I don't know if this was the best approach. Please let me know so that I can fix the changes 😄 |
README.md
Outdated
| * [Team](#team) | ||
| * [Copyright/License](#copyright-license) | ||
| * [About thoughtbot](#about-thoughtbot) | ||
| - [Getting started](#getting-started) |
There was a problem hiding this comment.
Are the formatting changes to the README necessary in this PR or can we do this in a different PR? Is there something that forced this change?
There was a problem hiding this comment.
Oh, my bad. It was the linter 😅 Lemme fix it
HeitorMC
force-pushed
the
refactor/remove-rails-6-0-z
branch
from
7d0cb63
to
1abed79
Compare
|
Hi, @HeitorMC, LGTM! We only need to fix the conflict. |
HeitorMC
force-pushed
the
refactor/remove-rails-6-0-z
branch
from
1abed79
to
d0230fb
Compare
Done 👍 |
Removes Rails 6.0.z support due to EOL.