Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding notification webhook structure #120

Merged

Conversation

cbhoffman
Copy link
Contributor

This aims to ultimately support using webhooks for integrations within the ThousandEyes terraform provider.

Currently, if you create a custom webhook integration (for example, Microsoft Teams), you can't use it to create/update alert rules with webhook notifications (using an integration data source in terraform).

I think there just needs to be an additional struct, if this is wrong please let me know.

Any feedback would be appreciated!

Copy link
Collaborator

@joaomper-TE joaomper-TE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for the contribution! Do you mind adding a test covering the new Webhook in alerts_test.go?

@cbhoffman
Copy link
Contributor Author

LGTM, thanks a lot for the contribution! Do you mind adding a test covering the new Webhook in alerts_test.go?

Test added!

joaomper-TE
joaomper-TE previously approved these changes Dec 11, 2023
@cbhoffman
Copy link
Contributor Author

I'm also planning on creating a PR within the terraform-provider-thousandeyes repo. @pedro-te @raul-te @sfreitas-te may I have a code owner review when possible please. Thank you all for your work!

phpinhei-te
phpinhei-te previously approved these changes Dec 13, 2023
alert_test.go Outdated Show resolved Hide resolved
@shahid-te
Copy link
Collaborator

Thanks for contributing 😄

@shahid-te shahid-te merged commit 3b4f115 into thousandeyes:main Dec 13, 2023
1 check passed
@cbhoffman
Copy link
Contributor Author

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

@shahid-te
Copy link
Collaborator

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week.
You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

@cbhoffman
Copy link
Contributor Author

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week. You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

Any updates on when terraform-provider-thousandeyes will be updated? @shahid-te

@shahid-te
Copy link
Collaborator

Thanks for approvals and merging. Do you know when there will be a new release? @joaomper-TE @shahid-te

Done. Your changes are in v2.4.2. We'll also update this version in terraform-provider-thousandeyes this week. You mentioned that you're planning to raise a PR in that repo. Please go ahead and tag @joaomper-TE and me for review.

Any updates on when terraform-provider-thousandeyes will be updated? @shahid-te

We are in release freeze due to the holidays and will release in January beginning. Apologies for any inconvenience.

@cbhoffman
Copy link
Contributor Author

Hi @shahid-te, will there be a new terraform provider release this week?

@joaomper-TE
Copy link
Collaborator

Hey @cbhoffman , sorry for the long wait as we were all on 2 weeks of PTO. Will release a new version of TF provider today over this PR: thousandeyes/terraform-provider-thousandeyes#163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants