-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meta): refresh metastore if there is zdb up/down #129
Conversation
92e051e
to
a995b37
Compare
ce53683
to
b4018ec
Compare
I got some issue during encryption on 0-stor_v2/zstor/src/encryption.rs Line 80 in c5f1fba
but also happened on the master (before all of my changes), but can't reproduce it again. I'm checking it now. |
Do you aware of some issue with 0-stor_v2/zstor/src/encryption.rs Line 80 in c5f1fba
|
OK, i found the issue, use the wrong config for the encryption $ git diff
diff --git a/zstor/src/actors/backends.rs b/zstor/src/actors/backends.rs
index 6dd68eb..d9d2929 100644
--- a/zstor/src/actors/backends.rs
+++ b/zstor/src/actors/backends.rs
@@ -400,7 +400,7 @@ impl Handler<CheckBackends> for BackendManagerActor {
};
let Meta::Zdb(meta_config) = config.meta();
let encoder = meta_config.encoder();
- let encryptor = match meta_config.encryption() {
+ let encryptor = match config.encryption() {
Encryption::Aes(key) => AesGcm::new(key.clone()),
};
let new_cluster = ZdbMetaStore::new( |
i just found the Line 276 in c5f1fba
I tried to use it as well, but it doesn't meet usecase. If you like, i could do another PR to refactor that code, along with another improvements. |
Yes, feel free to do so if it is an improvement to the code |
part of #127 :