(QA verification) 🐞 [Bug]: Rentable filter is not working fine

[khaledyoussef24]

Is there an existing issue for this?

• I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

Used rentable filter to rent a node on quanet with dediacted filter
got this

used dedicated node only got these

used dedicated node and status up got these

i think rentable filter supposed to show any node ready for rent status up or standby

Steps To Reproduce

No response

which network/s did you face the problem on?

QA

version

2.5

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

.

Relevant log output

.

[Mahmoud-Emad]

Issue Update

Investigation and Solution

I think there are no issues, when you enter your filter in the dashboard, you basically append a new key in the route URL

Requests

1. Rentable filter

2. Dedicated filter

3. Dedicated && Rentable

Based on @Omarabdul3ziz

two nodes in the second url are on freefarm2 which is a dedicated farm.
means that only its nodes can be rented to be available for use. query looks fine it is dedicated=true and also rentable=true
the first URL has the extra query available_for which excludes the freefarm2 nodes cause they are neither rented by this twin id NOR not in un dedicated farm.

Does that mean the nodes here are not available for the requested twin? exactly.

[A-Harby]

Actually, the logic isn't correct; let me explain.

As you can see below, there are 2 nodes dedicated and free to be reserved (Nodes 4, 5, and 26).

But when I turn on the rentable flag, I only see 1 node, and the other node is not listed (node 4 would also not be listed here if I didn't reserve it).

The rentable logic should be to list all the free-to-rent nodes, either shared with no contract or dedicated and not reserved.

So in conclusion, the dedicated node flag is working, but rentable is not.

Also, other option What is the point of showing the offline node as rentable? They are not rentable by any means.

[Mahmoud-Emad]

@A-Harby

You are right that the "available for" shouldn't be there in that case.
Additionally, for the second point, it's not a problem at all, since users can choose their filters. We have a drop-down that contains all the types of statuses, so if you want to see the online nodes only, you can select "up" from the drop-down, and so on. I also want to let you know that even if the user forgets to select the "up" status, we order the nodes based on their status, which means the "up" nodes come first, and then any other status.

[A-Harby]

Verified, QA 2.5.0-rc3.

Now the dedicated node flag show all the dedicated now (rented and free).

But the rentable only shows the free ones.