[Mainnet]🐞 [Bug]: Rentable filter in node finder shows all dedicated nodes

[khaledyoussef24]

Is there an existing issue for this?

• I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

#2143

should not the rentable filter shows only nodes which allows to be rented (up and stand by only)

Steps To Reproduce

No response

which network/s did you face the problem on?

QA

version

2.4.0

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Relevant log output

na

[khaledyoussef24]

The rentable filter shows all nodes that are rentable and does not exclude the nodes that are down

show rentable should only show

• up or stand-by nodes.
• ready for renting nodes (not rented by another user).

[Mahmoud-Emad]

The rentable filter shows all nodes that are rentable and does not exclude the nodes that are down

show rentable should only show

• up or stand-by nodes.
• ready for renting nodes (not rented by another user).

While the reserve button disappear when the node is down it's not a problem, the user will discover only the node details, also, as a user and i have some dedicated nodes, i want to see all of them at some point

[khaledyoussef24]

in that case the dedicated filter is already there.

[A-Harby]

Testnet, 2.4.0.

I tried to search for dedicated nodes, and with the up status, I found a few nodes, all of which were rentable.

Then I switched to rentable and up status, but I only found 1 node despite having more, as you can see in the picture above.

And the same happened on other status, so is it a bug ?
And the difference between dedicated and rentable is very confusing.

[0oM4R]

@A-Harby resolved on #2960

Testnet, 2.4.0.

I tried to search for dedicated nodes, and with the up status, I found a few nodes, all of which were rentable. Then I switched to rentable and up status, but I only found 1 node despite having more, as you can see in the picture above.

And the same happened on other status, so is it a bug ? And the difference between dedicated and rentable is very confusing.

[0oM4R]

Issue update

work completed :
introduce new flow for this toggle:

• if the Status filter is not selected ->> the status filter will be updated to Up and Standby
• if the Status filter has any value -> nothing new happen, will keep it as it is

Screencast.from.03.2024.EEST.07.13.56.webm

@ehab-hassan what do you think about this flow?

[ehab-hassan]

As we discussed with @AhmedHanafy725 and @0oM4R, 'Rentable' means that the user needs to reserve an 'Up' or 'Standby' node. Therefore, let's freeze the 'Select Node Status' field to 'Up' and 'Standby' when the 'Rentable' toggle is active.

[khaledyoussef24]

verified on mainnet
Version 2.6.0
Rentable now when toggled is automatically shows dedicated nodes with status up and standby



testcase