Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better generated leader name for caprover #1001

Merged
merged 6 commits into from
Aug 20, 2023
Merged

Better generated leader name for caprover #1001

merged 6 commits into from
Aug 20, 2023

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Aug 16, 2023 •
edited
Loading

image

Screenshot from 2023-08-16 14-11-26

@AlaaElattar AlaaElattar marked this pull request as draft August 16, 2023 10:51
@AlaaElattar AlaaElattar marked this pull request as ready for review August 16, 2023 11:14
zaelgohary
zaelgohary requested changes Aug 20, 2023
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same generateName function is being called in all solutions, so I think it'd be better if we adjusted the length in all of them to match what's been done in Caprover.

@AlaaElattar AlaaElattar changed the base branch from development to development_312 August 20, 2023 12:29
@AlaaElattar AlaaElattar merged commit d7e56f1 into development_312 Aug 20, 2023
3 checks passed
@AlaaElattar AlaaElattar deleted the development_improve_caprover_name branch August 20, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlaaElattar @zaelgohary