Checking for free public IPs before deploying the instances #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid and
Omarabdul3ziz
as code owners
…rid proxy, created a new method 'checkFarmIps' inside the 'TwinDeploymentHandler' to check if the deployment farm has the requested ips
Mahmoud-Emad
force-pushed
the
development_check_farmIps
branch
from
8a63ee3
to
3e051b5
Compare
AhmedHanafy725
requested changes
Oct 8, 2023
AhmedHanafy725
approved these changes
Oct 9, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Declared a new field that matches the farmId in the response of the grid proxy, created a new method 'checkFarmIps' inside the 'TwinDeploymentHandler' to check if the deployment farm has the requested ips
Related Issues
Screenshots
Checklist