Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support offline node contract notification on mainnet #1297

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Support offline node contract notification on mainnet #1297

merged 14 commits into from
Oct 31, 2023

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Oct 29, 2023 •
edited
Loading

This is open to be attached to the mainnet as a patch release.

Support links in the notification pop-up

  • image
  • image

The original issue description

Description

  • Added a notification helper that will notify the user every 15 minutes if there are deployments on an offline node.
  • Updated the toast warning background, icon color, and text color in dark/light mode.

Related Issues

Screenshots

  • image

@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft October 29, 2023 08:56
@Mahmoud-Emad Mahmoud-Emad mentioned this pull request Oct 29, 2023
Closed
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review October 29, 2023 13:15
@amiraabouhadid amiraabouhadid self-assigned this Oct 29, 2023
@0oM4R 0oM4R self-assigned this Oct 29, 2023
amiraabouhadid
amiraabouhadid requested changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the notification colors. I could not even read what is written in them.

image

@Mahmoud-Emad
Copy link
Contributor Author

@amiraabouhadid try to clear your cache keda

@0oM4R
Copy link
Contributor

0oM4R commented Oct 30, 2023

image
working fine with me, I think it will be better to close that toast by clicking on the contracts link, as the user will be redirected the contracts list page.

@Mahmoud-Emad
Copy link
Contributor Author

image working fine with me, I think it will be better to close that toast by clicking on the contracts link, as the user will be redirected the contracts list page.

Done :)

0oM4R
0oM4R approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job thank you!

@Mahmoud-Emad Mahmoud-Emad mentioned this pull request Oct 30, 2023
Closed
@AlaaElattar
Copy link
Contributor

  • worked fine with me.

@AhmedHanafy725 AhmedHanafy725 merged commit e1c2821 into development Oct 31, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the v2.1.1_hotfix_notifacation branch October 31, 2023 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees

@amiraabouhadid amiraabouhadid

@0oM4R 0oM4R

Labels
playground
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mahmoud-Emad @0oM4R @AlaaElattar @AhmedHanafy725 @amiraabouhadid