Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug of listing vms && add contract Id. #1317

Merged
merged 14 commits into from
Oct 31, 2023
Merged

Fix bug of listing vms && add contract Id. #1317

merged 14 commits into from
Oct 31, 2023

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented Oct 31, 2023 •
edited
Loading

image

Screenshot from 2023-10-31 11-00-33

@AlaaElattar AlaaElattar marked this pull request as draft October 31, 2023 07:31
@AlaaElattar AlaaElattar marked this pull request as ready for review October 31, 2023 09:13
@zaelgohary
Copy link
Contributor

There is one case where we won't be able to get the contract id which is if encryption didn't happen. In this case, we need to show a more meaningful message like "unknown contract id as it was not decrypted".

@AlaaElattar
Copy link
Contributor Author

There is one case where we won't be able to get the contract id which is if encryption didn't happen. In this case, we need to show a more meaningful message like "unknown contract id as it was not decrypted".

will it be good to show msg next to deployment name or just not to show with contract as we do with nodeId.

@zaelgohary
Copy link
Contributor

There is one case where we won't be able to get the contract id which is if encryption didn't happen. In this case, we need to show a more meaningful message like "unknown contract id as it was not decrypted".

will it be good to show msg next to deployment name or just not to show with contract as we do with nodeId.

Sure we can do that.

@AlaaElattar
Copy link
Contributor Author

There is one case where we won't be able to get the contract id which is if encryption didn't happen. In this case, we need to show a more meaningful message like "unknown contract id as it was not decrypted".

will it be good to show msg next to deployment name or just not to show with contract as we do with nodeId.

Sure we can do that.

done

@AhmedHanafy725 AhmedHanafy725 merged commit 93da6e3 into development Oct 31, 2023
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_bug_listing branch October 31, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0oM4R 0oM4R 0oM4R left review comments

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@MohamedElmdary MohamedElmdary MohamedElmdary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AlaaElattar @zaelgohary @MohamedElmdary @AhmedHanafy725 @0oM4R