Support sorting from GridProxy in Contracts List page #3171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the GridProxy client to include `SortBy` and `SortOrder` fields - Created a new enum to store the values accepted by the proxy - Validated the incoming value before sending it to the proxy
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
- Updated table fields to support only accepted sortable fields. - Removed outdated sort function and integrated Grid Proxy client for sorting.
xmonader
reviewed
Jul 28, 2024
…ed from the nodes file.
samaradel
approved these changes
Jul 29, 2024
amiraabouhadid
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support sorting from GridProxy on the Contracts List page
Changes
SortByandSortOrderfieldsRelated Issues
Checklist