Validate hex seed in case activate account #3474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samaradel
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar and
0oM4R
as code owners
xmonader
reviewed
Sep 29, 2024
|
Can you please update the PR description with the new changes? and explanation would be great addition. |
xmonader
approved these changes
Oct 2, 2024
0oM4R
reviewed
Oct 2, 2024
Comment on lines
731
to
735
| const mnemonicValue = validateMnemonic(mnemonic.value) | ||
| ? mnemonic.value | ||
| : mnemonic.value.length === 66 | ||
| ? mnemonic.value | ||
| : `0x${mnemonic.value}`; |
There was a problem hiding this comment.
should we use if/else if ? i think it will be more readable
There was a problem hiding this comment.
I think it's good, less code, and the results depend on the previous one. it's fine.
@AhmedHanafy725 what do you think ?
There was a problem hiding this comment.
it's fine but what confuses me is the variable name, it can be mnemonic or hex seed
0oM4R
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes
Screencast.from.26-09-24.16.39.33.webm
Related Issues
Tested Scenarios
0xin the beginning and activate the account.Checklist