Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning message #813

Merged
merged 3 commits into from
Jul 16, 2023
Merged

add warning message #813

merged 3 commits into from
Jul 16, 2023

Conversation

Omarabdul3ziz
Copy link
Contributor

@Omarabdul3ziz Omarabdul3ziz commented Jul 16, 2023 •
edited
Loading

AhmedHanafy725
AhmedHanafy725 reviewed Jul 16, 2023
View reviewed changes
packages/playground/src/weblets/tf_presearch.vue Outdated
Comment on lines 21 to 22
You can deploy only one Presearch node per farm without reserving a dedicated public IP. So a Presearch's node
is deployed without public IP and didn't show up in the Presearch's Dashboard that's means there is another
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can deploy only one Presearch node per farm without reserving a dedicated public IP. So a Presearch's node
is deployed without public IP and didn't show up in the Presearch's Dashboard that's means there is another
You can deploy only one Presearch node per farm without reserving a dedicated public IP. So if a Presearch's node
is deployed without public IP and didn't show up in the Presearch's Dashboard that means there is another

@xmonader xmonader merged commit 1f1b7d0 into development Jul 16, 2023
@xmonader xmonader deleted the development_playground/presearch/warning_message branch July 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Omarabdul3ziz @zaelgohary @AhmedHanafy725 @xmonader