Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Drop hub command from the RELEASE.md #585

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

r-hang
Copy link
Contributor

@r-hang r-hang commented Jun 9, 2023

The current RELEASE.md relies on the hub command. I ran into authorization issues while trying to use hub for the release that were not easy to resolve. The problems I encountered are captured in a still open hub issue: mislav/hub#2655. Given the extra steps required to work around and resolve this issue, I think it would be simpler to frame the release instructions in terms of local git commands and Github UI.

This change updates the RELEASE.md to replace hub commands with local git commands and Github UI instructions.

The current RELEASE.md relies on the `hub` command. I ran into authorization
issues while trying to use `hub` for the release that were not easy to
resolve. The problems I encountered are captured in a still open `hub`
issue: mislav/hub#2655. Given the extra steps
required to work around and resolve this issue, I think it would be
simpler to frame the release instructions in terms of local `git`
commands and Github UI.

This change updates the RELEASE.md to replace `hub` commands with local
`git` commands and Github UI instructions.
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #585 (957045b) into dev (b9b2699) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #585   +/-   ##
=======================================
  Coverage   68.01%   68.01%           
=======================================
  Files         142      142           
  Lines       23878    23878           
=======================================
  Hits        16241    16241           
  Misses       4577     4577           
  Partials     3060     3060           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

RELEASE.md Outdated Show resolved Hide resolved
Co-authored-by: JacobOaks <[email protected]>
@r-hang r-hang merged commit 8fb12f0 into dev Jun 13, 2023
@r-hang r-hang deleted the rhang/update-release-docs branch June 13, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants