Features/579 login rework #640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added generic modal component * Adjusted TextInput to delay invalid styling until first interaction * Added help message to TextInput * Adjust login screen to use generic modal over a home-view component
devmount
approved these changes
Sep 10, 2024
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
MelissaAutumn
temporarily deployed
to
staging
GitHub Actions
Inactive
devmount
added a commit
that referenced
this pull request
Sep 11, 2024
* Features/579 login rework (#640) * Initial pass on login re-work: * Added generic modal component * Adjusted TextInput to delay invalid styling until first interaction * Added help message to TextInput * Adjust login screen to use generic modal over a home-view component * Fix custom validation * Array<T> -> T[] * Fix padding on homepage, fix copywrite year, and add report bug link to navbar, * Re-enable redis + use cluster mode * Fix for redis error in cluster mode * Redis debugging * Revert "Redis debugging" This reverts commit da0bb0a. * Add some performance profiling for redis * Upgrade posthog * Try a suggested param to speed up cluster booting * Try eager loading calendars for appointment.get_by_subscriber * Eager load on joined for apmt slots and attendees * Revert "Eager load on joined for apmt slots and attendees" This reverts commit 1910ab3. * Fix error with eager loading * Connect to the redis cluster at the start of the app * ...actually hook up the lifespan function * Adjust retry strategy for redis cluster * Login Re-work Pt2 (#646) * Re-work waiting list action, and string extract. * Update confirm your email...email * 🌐 Update German translation, sort lang keys --------- Co-authored-by: Andreas Müller <[email protected]> --------- Co-authored-by: Mel <[email protected]> Co-authored-by: Melissa Autumn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First half of #579
This is just the login part of the work. I still need to complete the waiting list post-action screens and email...and I haven't pulled in the localization just yet. This is to unblock devmounts work.
This adds a generic modal which we can use within Appointment (unless it's a multi-service design, cc @laurelterlesky). I fake the background by loading in the background's view component within the logins view component 😄
Screenshots