Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schedule creation UI enhancement #683

Merged
merged 5 commits into from
Sep 25, 2024

Conversation

devmount
Copy link
Collaborator

Description of the Change

This change implements most of the remaining tasks to implement the current design for the schedule creation section:

  • Input labels
  • Spacing
  • Snackish bar
  • Light / dark mode

Benefits

image

a

Applicable Issues

Closes #460

@devmount devmount self-assigned this Sep 24, 2024
Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

frontend/src/components/ScheduleCreation.vue Outdated Show resolved Hide resolved
@devmount
Copy link
Collaborator Author

@MelissaAutumn If you like you can test again, I added the checkbox component now.

@MelissaAutumn
Copy link
Member

Looks like I can still edit the weekday selections and the slug input while the schedule is disabled. I'll make a ticket so it doesn't block the merge of this though.

@MelissaAutumn MelissaAutumn merged commit fa4c82a into main Sep 25, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the enhancements/460-schedule-creation-ui branch September 25, 2024 15:40
@devmount
Copy link
Collaborator Author

Looks like I can still edit the weekday selections and the slug input while the schedule is disabled. I'll make a ticket so it doesn't block the merge of this though.

Good catch! Yes please create a ticket, I'll look into that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No Confirmation Needed" or "Confirmation Needed"
2 participants