Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle generic modal close event #721

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

devmount
Copy link
Collaborator

Description of the Change

This PR adds event handling for a close emit from the GenericModal.

Benefits

Close buttons on the waiting list modal will work now.

Applicable Issues

Closes #719

@devmount devmount self-assigned this Oct 15, 2024
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just an indentation fix. Nothing changed in this file.

Copy link
Member

@MelissaAutumn MelissaAutumn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@MelissaAutumn MelissaAutumn merged commit 635b4fe into main Oct 15, 2024
4 checks passed
@MelissaAutumn MelissaAutumn deleted the bugs/719-close-waiting-list-modal branch October 15, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal close X from beta confirmation link doesn’t close the modal
2 participants