"Sign in with Google" Button text not readable in dark mode

[sivasubramaniamv]

Checklist

• I have used the search function to see if someone else has already submitted the same bug report.
• I will describe the problem with as much detail as possible.

App version

6.602

Where did you get the app from?

Google Play

Android version

Android 11

Device model

Realme 3 Pro

Steps to reproduce

1. Enable system-wide dark mode
2. Do a fresh install and open the app
3. Click "Next" on Welcome Screen
4. Enter a Gmail address and click "Next"
5. Notice that the button text ("Sign in with Google") is not readable

Expected behavior

The button text should be in a dark color

Actual behavior

The button text color is white

Logs

[sivasubramaniamv]

@cketti I fixed this bug locally in a new branch, pushed it to my fork on GitHub, and went on to create a pull request.

• Does not contain merge commits. Rebase instead.

This was mentioned on the pull request page. I looked up what rebase is in Git and learned that it is a mechanism to combine changes from one branch into another, a potentially better alternative to merging.

But I'm confused about what I should do on my side as merging/rebasing is concerned with maintainers and not contributors.

Can you help me?

[cketti]

When your pull request branch lives for a while, chances are that our main branch will see some additional commits. If one of the commits introduces changes that conflict with the changes in your pull request, you need to update the pull request to resolve this conflict. What we're asking is that in such a case you should rebase on our updated version of main rather than merging our updated main branch into your pull request branch.

This is probably not relevant for your fix. Just go ahead and create the pull request.

[sivasubramaniamv]

Thank you :)