Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appearance of "Sign in with Google" button #6928

Merged
merged 2 commits into from
May 26, 2023
Merged

Fix appearance of "Sign in with Google" button #6928

merged 2 commits into from
May 26, 2023

Conversation

sivasubramaniamv
Copy link
Contributor

fixes #6924

Before

oauth_sign_in_button

After

oauth_signin_button_changed

@cketti
Copy link
Member

cketti commented May 25, 2023

Whenever you see something like this, ask yourself why. Manually specifying a hard-coded color is extra work and doesn't make sense given that the app supports multiple themes. So it's likely there was a good reason for that.

Checking out the PR that introduced this screen should give you an idea: #6096

The button should display the custom Google design. This no longer works because we switched to a material theme and now a <Button> element is inflated as a MaterialButton which doesn't support the android:background attribute.

Changing

<Button
    android:id="@+id/google_sign_in_button"

to

<androidx.appcompat.widget.AppCompatButton
    android:id="@+id/google_sign_in_button"

should fix the issue.

@sivasubramaniamv
Copy link
Contributor Author

@cketti I've changed it. Thank you :)

@cketti cketti changed the title Removed hard coded text color in google sign-in button to improve readability in dark mode Fix appearance of "Sign in with Google" button May 26, 2023
@cketti cketti merged commit 89e55b2 into thunderbird:main May 26, 2023
@cketti
Copy link
Member

cketti commented May 26, 2023

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Sign in with Google" Button text not readable in dark mode
2 participants