Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added catch block for InvalidDnsNameException #8546

Conversation

Its-Aki
Copy link
Contributor

@Its-Aki Its-Aki commented Nov 11, 2024

Issue: Fixes #8502

Summary: This pull request addresses a crash that occurs when setting up an account due to an InvalidDnsNameException.

Changes:

Added a catch block for InvalidDnsNameException in MxLookupAutoconfigDiscovery.kt.
Logged the exception using Timber.d.
Impact: This change prevents the application from crashing when an invalid DNS name is encountered during account setup.

@kewisch kewisch added the task: backport Backport to the latest stable version once the code got some exposure in beta label Nov 12, 2024
Copy link
Member

@cketti cketti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@cketti cketti merged commit 5627edf into thunderbird:main Nov 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task: backport Backport to the latest stable version once the code got some exposure in beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when setting up an account
3 participants