Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Angular 17 support #2196

Closed
devgojokotech opened this issue Dec 20, 2023 · 5 comments · Fixed by #2197
Closed

[Feature]: Angular 17 support #2196

devgojokotech opened this issue Dec 20, 2023 · 5 comments · Fixed by #2197

Comments

@devgojokotech
Copy link

🚀 Feature Proposal

We need to update the import zone.js/bundles/zone-testing.js and zone.js/dist/zone to zone.js and zone.js/testing as they are updates now in angular version 17, it leads to incompatible issue while upgrading from 17.

Motivation

It will add compatibility for angular 17.

Example

.
@kpeters-cbsi
Copy link

So is jest-preset-angular not compatible with Angular 17?

@devgojokotech
Copy link
Author

Yeah its not as of now, due to zonejs import path
Screenshot 2023-12-21 at 10 37 42 AM

@cfrezier
Copy link

cfrezier commented Dec 21, 2023 •
edited
Loading

We also need this, and adapting package version requirements would also be helpfull.

@ahnpnl
Copy link
Collaborator

ahnpnl commented Dec 25, 2023

We already made a release with updated zone import, see #2163

johncrim added a commit to johncrim/jest-preset-angular that referenced this issue Jan 3, 2024
@johncrim
chore(upgrade ng): Upgrade to ng17 latest
2c488d5 
Tests pass, and example tests pass.

resolves: [Feature]: Angular 17 support  thymikee#2196
@johncrim johncrim mentioned this issue Jan 3, 2024
Merged
2 tasks
johncrim added a commit to johncrim/jest-preset-angular that referenced this issue Jan 3, 2024
@johncrim
chore(upgrade ng): Upgrade to ng17 latest
5f3effb 
Tests pass, and example tests pass.

resolves: [Feature]: Angular 17 support  thymikee#2196
ahnpnl pushed a commit that referenced this issue Jan 3, 2024
@johncrim
fix: Fix TS5 + ESM hang; and upgrade dev dependencies to ng17 (#2197)
90797e5 
* fix(ts5): Update build dependencies and types for TS 5

This update appears to fix #2138. It builds with TS 5, and all tests and example tests pass.

fixes: [Bug]: ESM with TypeScript >= 5.0 hangs forever #2138

* chore(deps): Add Husky dev dependency

Husky is required by the postinstall script, but was previously missing.

* chore(upgrade ng): Upgrade to ng17 latest

Tests pass, and example tests pass.

resolves: [Feature]: Angular 17 support  #2196

* chore(dedupe): yarn dedupe

* fix(eslint): Disable eslint warnings due to use of "any"

* chore(deps): Change dev dependency for TS to match @angular/compiler restrictions
@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 3, 2024

Should be fixed with v13.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TS5 + ESM hang; and upgrade dev dependencies to ng17 johncrim/jest-preset-angular
4 participants
@cfrezier @ahnpnl @kpeters-cbsi @devgojokotech