Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade peer dependency to jest 24 #223

Closed
markgoho opened this issue Jan 26, 2019 · 7 comments
Closed

upgrade peer dependency to jest 24 #223

markgoho opened this issue Jan 26, 2019 · 7 comments

Comments

@markgoho
Copy link

Jest 24 was released yesterday, Jan 25. It looks like there are quite a few breaking changes. What needs to be done to help this library upgrade it's pear dependency to Jest 24?

@ahnpnl
Copy link
Collaborator

ahnpnl commented Jan 26, 2019

We are still discussing about whether we switch from ts-jest to use @babel/preset-typescript since jest 24 supports ts by default. That is the most concerned point at this moment. Besides, I saw there is a small change in jest config like deprecated setupTestFrameworkScriptFile. I don't know what else changes in config of jest.

@thymikee would you please summarize anything else change in jest config beside setupTestFrameworkScriptFile ?

@thymikee
Copy link
Owner

Just checked locally and Jest 24 works without any changes from our side (if you don't mind deprecation warning)

@thymikee thymikee mentioned this issue Jan 26, 2019
@thymikee
Copy link
Owner

FYI kulshekhar/ts-jest#957

@SimenB
Copy link

SimenB commented Feb 1, 2019

We are still discussing about whether we switch from ts-jest to use @babel/preset-typescript since jest 24 supports ts by default.

FWIW, personally I'd like to see ts-jest still be a thing - there's probably quite a few people that would like to typecheck their tests (and have Jest respect tsconfig etc, which we'll never do out of the box).

@lup0r
Copy link

lup0r commented Feb 21, 2019

Just checked locally and Jest 24 works without any changes from our side (if you don't mind deprecation warning)

That is, if you don't have other presets or config. Because you can't use both old and new form together, which gives you an error.

thymikee added a commit that referenced this issue Mar 4, 2019
This is a PoC. Jest 24 works without any changes from our side. It added some defaults to TS but we use slightly different ones (e.g. no `.tsx`).

However, until `ts-jest` updates, we'll likely need to hold off with the upgrade, because of peer dep warnings.

Fixes #223
@slawiko
Copy link

slawiko commented Mar 5, 2019

👍
When we can expect release with this fix? Thanks in advance :)

@thymikee
Copy link
Owner

thymikee commented Mar 5, 2019

@slawiko It's released in next tag as 7.0.0-alpha.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants