Remove testRegex out of preset #131

ahnpnl · 2018-03-07T08:53:05Z

Jest default set up testMatch to get all the test files to run. Removing testRegex out of the preset will bring flexibility to the users to set up their own testMatch/testRegex.

thymikee · 2018-03-07T08:54:49Z

jest-preset.json

@@ -8,7 +8,6 @@
  "transform": {
    "^.+\\.(ts|js|html)$": "<rootDir>/node_modules/jest-preset-angular/preprocessor.js"
  },
-  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$",
  "moduleFileExtensions": [


Ugh, but Jest will not match *.ts files by default. Why not changing it to testMatch?

hmm, but if we add testMatch, people who want to use testRegex won't be able to run the tests. I think we should put testMatch to the README inside installation setup.

But testRegex is already set and we write about it in README, so it will be the same situation. I'm not going to remove the default. One can always override it without any issues. Both cannot work with each other and Jest will warn you about it:

https://github.com/facebook/jest/blob/f1c422f58ab05010ccbfd42902248946e5924860/packages/jest-config/src/normalize.js#L582-L587

ah ok then I'll adjust testRegex to be testMatch 👍

thymikee · 2018-03-07T09:59:09Z

jest-preset.json

-  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$",
+  "testMatch": [
+    "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$"
+  ],


Can you adjust the readme and changelog as well?

thymikee · 2018-03-07T12:24:03Z

README.md

@@ -45,7 +45,9 @@ import './jestGlobalMocks'; // browser mocks globally available for every test
  "transform": {
    "^.+\\.(ts|js|html)$": "<rootDir>/node_modules/jest-preset-angular/preprocessor.js"
  },
-  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$",
+  "testMatch": [
+    "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$"


This is wrong. Here's the default one (where I just found a bug XD):

[ '**/__tests__/**/*.js?(x)', '**/?(*.)(spec|test).js?(x)' ]

and we rather want to change it to:

[ '**/__tests__/**/*.+(ts|js)?(x)', '**/?(*.)+(spec|test).+(ts|js)?(x)' ]

oh those 2 are default from Jest 👍

thymikee

did you make sure it works on current projects?

ahnpnl · 2018-03-07T13:11:22Z

I think the regex is not good enough. Just try yarn pack and install it into example app. It doesn't exclude src/test.ts .
I'd prefer this one
"testMatch": [ "**/__tests__/**/*.(ts|js)?(x)", "**/?(*.)(spec|test).(ts|js)?(x)" ]

But I still can't ignore src/test.ts yet

Updated:
This one seems to work well:
[ "**/__tests__/**/*.(ts|js)?(x)", "**/?*.(spec|test).(ts|js)?(x)" ]

thymikee · 2018-03-07T13:41:15Z

I think the second part should be

"**/+(*.)(spec|test).(ts|js)?(x)"

ahnpnl · 2018-03-07T13:44:41Z

Tested with new project generated with CLI: OK
Tested with example inside the repo: still fails with src/test.ts
Updated: I think it's good now. My mistake didn't generate the new package for example

thymikee · 2018-03-07T14:04:07Z

See this: http://www.globtester.com/#p=eJzT0tLX1tDS09TWKC5ITa4pSS0u0dTT1igprskq1rTXqNAEAJdZCa0%3D&r=eJyzScksU0jOSSwutlVSsisuStYvSS0u0csqttEHytjZIEnnJpYkZ0DU5FbqoSgDAFtkGGY%3D&

ahnpnl · 2018-03-07T14:18:59Z

Updated in the latest commit 👍

thymikee · 2018-03-07T15:00:51Z

README.md

@@ -66,7 +69,7 @@ import './jestGlobalMocks'; // browser mocks globally available for every test
 * `<rootDir>` is a special syntax for root of your project (here by default it's project's root /)
 * we're using some `"globals"` to pass information about where our tsconfig.json file is that we'd like to be able to transform HTML files through ts-jest
 * `"transform"` – run every TS, JS, or HTML file through so called *preprocessor* (we'll get there); this lets Jest understand non-JS syntax
-* `"testRegex"` – we want to run Jest on files that matches this regex
+* `"testMatch"` – we want to run Jest on files that matches this regex


thymikee · 2018-03-07T15:02:43Z

jest-preset.json

-  "testRegex": "(/__tests__/.*|\\.(test|spec))\\.(ts|js)$",
+  "testMatch": [
+    "**/__tests__/**/*.(ts|js)?(x)",
+    "**/+(*.)(spec|test).(ts|js)?(x)"


we should also add +s before the (..|..) groups, because that's a valid glob. What we use currently at Jest (and I filed a PR to fix it: jestjs/jest#5744) uses an extra feature from micromatch library.

"**/__tests__/**/*.+(ts|js)?(x)", "**/+(*.)+(spec|test).+(ts|js)?(x)"

thymikee · 2018-03-07T15:29:04Z

Thanks for sticking with me!

ahnpnl · 2018-03-07T15:30:13Z

Thank you too. I learnt something new about glob as well

thymikee · 2018-03-07T15:30:46Z

Me too!

Remove testRegex out of preset

cd3885d

thymikee reviewed Mar 7, 2018

View reviewed changes

Change testRegex to testMatch

3fba76e

thymikee reviewed Mar 7, 2018

View reviewed changes

Anh Pham (NL-DEV) added 2 commits March 7, 2018 11:04

Update changelog and readme

25109d5

Adjust correct pull request number for CHANGELOG

f569a17

thymikee reviewed Mar 7, 2018

View reviewed changes

Update testMatch regex

4436d57

thymikee approved these changes Mar 7, 2018

View reviewed changes

Update regex to match tests

ae21c4f

thymikee reviewed Mar 7, 2018

View reviewed changes

Anh Pham (NL-DEV) added 2 commits March 7, 2018 16:07

update readme

40c39c6

Update testMatch to be valid glob

048ac1d

thymikee merged commit d7ffd1b into thymikee:master Mar 7, 2018

ahnpnl deleted the fix/remove-testregex branch March 7, 2018 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove testRegex out of preset #131

Remove testRegex out of preset #131

ahnpnl commented Mar 7, 2018

thymikee Mar 7, 2018

ahnpnl Mar 7, 2018

thymikee Mar 7, 2018 •

edited

Loading

ahnpnl Mar 7, 2018

thymikee Mar 7, 2018

thymikee Mar 7, 2018

ahnpnl Mar 7, 2018

thymikee left a comment

ahnpnl commented Mar 7, 2018 •

edited

Loading

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018 •

edited

Loading

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018

thymikee Mar 7, 2018

thymikee Mar 7, 2018

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018

thymikee commented Mar 7, 2018

Remove testRegex out of preset #131

Remove testRegex out of preset #131

Conversation

ahnpnl commented Mar 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thymikee Mar 7, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thymikee left a comment

Choose a reason for hiding this comment

ahnpnl commented Mar 7, 2018 • edited Loading

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018 • edited Loading

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

thymikee commented Mar 7, 2018

ahnpnl commented Mar 7, 2018

thymikee commented Mar 7, 2018

thymikee Mar 7, 2018 •

edited

Loading

ahnpnl commented Mar 7, 2018 •

edited

Loading

ahnpnl commented Mar 7, 2018 •

edited

Loading