Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target angular 16 #2061

Merged
merged 4 commits into from
May 5, 2023
Merged

Target angular 16 #2061

merged 4 commits into from
May 5, 2023

Conversation

PieterjanDeClippel
Copy link
Contributor

Summary

Target angular 16

Does this PR introduce a breaking change?

  • Yes
  • No

@PieterjanDeClippel
Copy link
Contributor Author

Rebased just now

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "jest-preset-angular",
"version": "13.0.1",
"version": "13.0.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe @ahnpnl bumps the version at release time. Not sure if it's appropriate to include it in this PR

Copy link
Collaborator

@ahnpnl ahnpnl May 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the version is bumped during the release process

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reset the version

@michaelfaith
Copy link
Contributor

michaelfaith commented May 5, 2023

This project uses yarn 3, which uses a cache for dependencies. So any changes to the package.json would need to also include updates to the yarn.lock. That's why the build is failing. You can run yarn to update the cache and lock file.

@PieterjanDeClippel
Copy link
Contributor Author

This project uses yarn 3, which uses a cache for dependencies. So any changes to the package.json would need to also include updates to the yarn.lock. That's why the build is failing. You can run yarn to update the cache and lock file.

Ok

@henryruhs
Copy link

Excuse me, how does bumping the dependencies solve the NGCC issue - should be disabled for Angular 16.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Jest: Got error running globalSetup - [...]/node_modules/jest-preset-angular/global-setup.js, reason: Package subpath './ngcc' is not defined by "exports" in [...]/node_modules/@angular/compiler-cli/package.json

@michaelfaith
Copy link
Contributor

michaelfaith commented May 5, 2023

Excuse me, how does bumping the dependencies solve the NGCC issue - should be disabled for Angular 16.

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Jest: Got error running globalSetup - [...]/node_modules/jest-preset-angular/global-setup.js, reason: Package subpath './ngcc' is not defined by "exports" in [...]/node_modules/@angular/compiler-cli/package.json

It doesn't. But there's a separate issue I opened for that, and you can just remove the global-setup from your config to get past that, until more robust error handling can be implemented. The offending code is highlighted in that issue, if you want to try and address it in a separate PR?

@ahnpnl
Copy link
Collaborator

ahnpnl commented May 5, 2023

@PieterjanDeClippel would you please run yarn dedupe and recommit the lock file?

@PieterjanDeClippel
Copy link
Contributor Author

@ahnpnl Ran yarn dedupe - Rebased

Copy link
Contributor

@michaelfaith michaelfaith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for taking this up

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahnpnl ahnpnl merged commit 18abd21 into thymikee:main May 5, 2023
@PieterjanDeClippel PieterjanDeClippel deleted the angular-16 branch May 7, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants