-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target angular 16 #2061
Target angular 16 #2061
Conversation
4d01cbb
to
76b874b
Compare
Rebased just now |
package.json
Outdated
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "jest-preset-angular", | |||
"version": "13.0.1", | |||
"version": "13.0.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe @ahnpnl bumps the version at release time. Not sure if it's appropriate to include it in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes the version is bumped during the release process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reset the version
This project uses yarn 3, which uses a cache for dependencies. So any changes to the |
Ok |
Excuse me, how does bumping the dependencies solve the NGCC issue - should be disabled for Angular 16.
|
It doesn't. But there's a separate issue I opened for that, and you can just remove the |
@PieterjanDeClippel would you please run |
e545665
to
e312f61
Compare
@ahnpnl Ran |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks for taking this up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Summary
Target angular 16
Does this PR introduce a breaking change?