Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): extend version support range to Angular 17 #2179

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

FrozenPandaz
Copy link
Contributor

Summary

Angular 17 is being released sometime this week (Week of November 6th, 2023). This PR allows for users to install jest-preset-angular without getting peerDependency errors which cause some package managers to fail the install process.

Test plan

We've tested jest-preset-angular + Angular 17 as part of the Angular 17 support for Nx and everything works other than a peer dependency error.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Collaborator

@ahnpnl ahnpnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ahnpnl ahnpnl merged commit 5434e22 into thymikee:main Nov 6, 2023
10 checks passed
@FrozenPandaz FrozenPandaz deleted the peer-ng17 branch November 6, 2023 20:08
@FrozenPandaz
Copy link
Contributor Author

Awesome, thank you!

Update: Angular 17 is slated for release on November 8th but we have some things to do in Nx so could you please release a version before that? 🤞

@ahnpnl
Copy link
Collaborator

ahnpnl commented Nov 6, 2023

should be out now :)

@FrozenPandaz
Copy link
Contributor Author

Fantastic, thank you so much! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants