Fix data race of DeltaIndexManager. (pingcap#4459) (pingcap#4472)

close pingcap#4405
ti-chi-bot · Mar 28, 2022 · 066f1b7 · 066f1b7
1 parent 5aea73d
commit 066f1b7
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/dbms/src/Storages/DeltaMerge/DeltaIndexManager.cpp b/dbms/src/Storages/DeltaMerge/DeltaIndexManager.cpp
@@ -92,9 +92,8 @@ void DeltaIndexManager::refreshRef(const DeltaIndexPtr & index)
         current_size += holder.size;
 
         removeOverflow(removed);
+        CurrentMetrics::set(CurrentMetrics::DT_DeltaIndexCacheSize, current_size);
     }
-
-    CurrentMetrics::set(CurrentMetrics::DT_DeltaIndexCacheSize, current_size);
 }
 
 void DeltaIndexManager::deleteRef(const DeltaIndexPtr & index)
@@ -124,9 +123,8 @@ void DeltaIndexManager::deleteRef(const DeltaIndexPtr & index)
         lru_queue.erase(holder.queue_it);
         // Remove it later
         index_map.erase(it);
+        CurrentMetrics::set(CurrentMetrics::DT_DeltaIndexCacheSize, current_size);
     }
-
-    CurrentMetrics::set(CurrentMetrics::DT_DeltaIndexCacheSize, current_size);
 }
 
 DeltaIndexPtr DeltaIndexManager::getRef(UInt64 index_id)