Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pingcap/kvproto): control reviewing approvals with prow OWNERS #1034

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Feb 29, 2024

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: ref pingcap/kvproto#1230

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Copy link

ti-chi-bot bot commented Feb 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 29, 2024
@ti-chi-bot ti-chi-bot bot requested a review from purelind February 29, 2024 10:00
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 29, 2024
@wuhuizuo wuhuizuo marked this pull request as ready for review April 2, 2024 07:56
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Apr 2, 2024

/cc @tonyxuqqi
PTAL

/hold
depends on pingcap/kvproto#1231

Copy link

ti-chi-bot bot commented Apr 2, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: tonyxuqqi.

Note that only ti-community-infra members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @tonyxuqqi
PTAL

/hold
depends on pingcap/kvproto#1231

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2024
@wuhuizuo
Copy link
Contributor Author

/cc @purelind

Copy link
Contributor

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Apr 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-12 04:21:41.938642404 +0000 UTC m=+1195363.466182950: ☑️ agreed by purelind.

Copy link

ti-chi-bot bot commented Apr 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Apr 12, 2024
@wuhuizuo
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit 01bbac9 into main Apr 12, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/review-control-for-kvproto-repo branch April 12, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants