Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tikv/rocksdb,tikv/rust-rocksdb): enable bot to control the reviewing flow #1103

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Aug 30, 2024

Signed-off-by: wuhuizuo [email protected]

What problem does this PR solve?

Issue Number: ref #824

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 30, 2024 08:33
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 30, 2024
@wuhuizuo wuhuizuo marked this pull request as draft August 30, 2024 08:47
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
@wuhuizuo wuhuizuo marked this pull request as ready for review August 30, 2024 12:35
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2024
@@ -22,7 +22,7 @@ approve:
commandHelpLink: "https://prow.tidb.net/command-help"
pr_process_link: "https://book.prow.tidb.net/#/workflows/pr"
lgtm:
- repos: [pingcap, ti-community-infra, PingCAP-QE, pingcap-inc]
- repos: [pingcap, tikv, ti-community-infra, PingCAP-QE, pingcap-inc]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikv/rust-rocksdb required just 1 LGTM.

@@ -40,6 +40,7 @@ lgtm:
- tikv/pd
- tikv/raft-engine
- tikv/tikv
- tikv/rocksdb
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tikv/rocksdb needs 2 LGTMs

@wuhuizuo
Copy link
Contributor Author

/cc @zhangjinpeng87

PTAL

Copy link

ti-chi-bot bot commented Aug 30, 2024

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: zhangjinpeng87.

Note that only ti-community-infra members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zhangjinpeng87

PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@zhangjinpeng87 zhangjinpeng87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

ti-chi-bot bot commented Aug 30, 2024

@zhangjinpeng87: changing LGTM is restricted to collaborators

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wuhuizuo wuhuizuo added the lgtm label Sep 2, 2024
@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Sep 2, 2024

/approve

Copy link

ti-chi-bot bot commented Sep 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo, zhangjinpeng87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2024
@ti-chi-bot ti-chi-bot bot merged commit 56a469d into main Sep 2, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/enable-bot-for-rocksdb branch September 2, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants