Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Handle renamed labels that don't show up in the labels for an issue #9

Merged
merged 1 commit into from
Jun 8, 2020

Conversation

tiangolo
Copy link
Owner

@tiangolo tiangolo commented Jun 8, 2020

🐛 Handle renamed labels that don't show up in the labels for an issue.

When a label is edited after added, the issue metadata in the API will contain the event for the old label but will have the new label.

So, while checking if the event where the label was added is older than the last comment, that event will have the old label name.

In short: it won't handle renamed labels that are not re-added to the issue after renaming. But it won't explode now.

@tiangolo tiangolo merged commit d756d82 into master Jun 8, 2020
@tiangolo tiangolo deleted the handle-renamed-labels branch June 8, 2020 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant