Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch url rewriter from js to typescipt #4

Merged
merged 2 commits into from
Feb 10, 2022

Commits on Feb 7, 2022

  1. Switch url rewriter from js to typescipt

    I pulled in a new library @aws-cdk/aws-lambda-nodejs that handles the
    transformation of javascript to typescript.  Had to patch up a couple of
    things which made this change a little more complex that intended.
    
    - All of the CDK components were not version locked, that meant
      depending on the order of npm installs they could drift and get into a
    dependancy mismatch spiral.  The version itself isn't important, its
    uniformity is all that matters.
    
    - Added permissions to the lambda role for interacting with cloudfronts
      distribution system, these were handled by the lambda function during
    deployment, but it seems this new library while handling the js -> ts
    brought some limitations and I had to manually implement the permssions see
    for details https://tinyurl.com/5xy3n8zt
    
    - Need to fix some typescript compliation issues, please feel free to
      re-work all of this and just keep the method signature
    
    Signed-off-by: Peter Nied <[email protected]>
    peternied committed Feb 7, 2022
    Configuration menu
    Copy the full SHA
    d6b2c44 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2022

  1. Configuration menu
    Copy the full SHA
    e2ac40d View commit details
    Browse the repository at this point in the history