Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add robot tests/integration tests like pytool-extensions #53

Open
spbrogan opened this issue Sep 26, 2022 · 2 comments
Open

Add robot tests/integration tests like pytool-extensions #53

spbrogan opened this issue Sep 26, 2022 · 2 comments
Assignees

Comments

@spbrogan
Copy link
Member

because basetools python applications are authored without python unit tests this project needs to validate at least as well as it did when it was integrated into the edk2 code tree.

To do that a robot framework based test can be used. See here for example: https://github.com/tianocore/edk2-pytool-extensions/tree/master/integration_test

This testing doesn't need to pass if for example you are making a breaking change, but by having this test the PR reviewers and author can confirm expected behavior.

@Javagedes Javagedes self-assigned this Sep 26, 2022
@spbrogan
Copy link
Member Author

Request was to make this a required check to pass. Maintainer/admin could override in the rare case of a breaking change.

@Javagedes
Copy link
Contributor

The platform build file's for EmulatorPkg, OvmfPkg, and ArmVirtPkg do not have the logic to detect and decide which of version of BaseTools to use (in-tree or pypi) like the CISetting files do. I've added that logic in a branch and will work on getting it into EDK2.

Until then, I've finished the integration tests and will add a PR so that the pipelines can be verified, but they will continue to run with the in-tree pytools until the platform build files are updated as I mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants