Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Integration tests #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Javagedes
Copy link
Contributor

As mentioned in #53, this PR is waiting for an update to the PlatformBuild.py files for OvmfPkg, ArmVirtPkg, and EmulatorPkg before this PR is merged.

The integration tests currently only run platform builds (IA32/X64, DEBUG/RELEASE). Please let me know if there are tools other than build that use BaseTools that you wish integration tests to be ran on, and I will add them to this PR.

@Javagedes Javagedes force-pushed the personal/joeyvagedes/integration_test branch from 67026cf to e8c7426 Compare September 28, 2022 20:18
@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Base: 4.28% // Head: 4.28% // No change to project coverage 👍

Coverage data is based on head (fa1bba4) compared to base (e2dc17a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #54   +/-   ##
======================================
  Coverage    4.28%   4.28%           
======================================
  Files         181     181           
  Lines       81448   81448           
======================================
  Hits         3493    3493           
  Misses      77955   77955           
Flag Coverage Δ
Linux 4.28% <ø> (ø)
Windows_NT 4.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Javagedes Javagedes force-pushed the personal/joeyvagedes/integration_test branch from e8c7426 to 458f216 Compare September 28, 2022 22:21
@Javagedes
Copy link
Contributor Author

Request to add additional architectures on the Linux / GCC5 build side.

@Javagedes Javagedes force-pushed the personal/joeyvagedes/integration_test branch from a14b92f to e7392eb Compare October 24, 2022 20:22
Integration tests to run platform builds with architectures IA32, X64
for targets DEBUG, RELEASE for platforms OvmfPkg, ArmVirtPkg, and
EmulatorPkg.

Signed-off-by: Joey Vagedes <[email protected]>
@Javagedes Javagedes force-pushed the personal/joeyvagedes/integration_test branch from 0a644ac to fa1bba4 Compare October 25, 2022 15:57
@mdkinney
Copy link
Member

mdkinney commented Mar 7, 2023

Have all the updates been made to support this PR?

@mdkinney mdkinney requested a review from BobCF March 7, 2023 23:44
@Javagedes
Copy link
Contributor Author

No, This bugzilla bug never made it in, which allows edk2 repo to build with basetools automatically:

https://bugzilla.tianocore.org/show_bug.cgi?id=4085

@ghost
Copy link

ghost commented Jun 16, 2024

@Javagedes Sorry I got swamped and am just trying to catch up on PRs in this repo.
Is this PR still relevant? If so, I'll review it and try and get it merged.

@Javagedes
Copy link
Contributor Author

@bcran this is still applicable, but quite old so it may be out of date. Let me review it again. I'm out next week so it'll be the following week that I can take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants